react-resplit v1 #19
Merged
react-resplit v1 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first iteration of this library was a hook-based API, with the idea that it would allow implementors more freedom to control the markup output by react-resplit. There were some challenges with this approach, given that the methods to register the container, panes and splitters all came from the core
useResplithook, which meant that it was harder to control the mounting and unmounting of the individual elements.This PR, and version
v1.0.0of react-resplit, replaces the hook-based API with a compound component API. Each of the resplit elements e.g. Root, Pane and Splitter, extenddivelements at the moment, but in a future iteration anasChildprop, based on the Radix UI composition technique, may be introduced to provide more flexibility there.