Allow stick deadzones to be applied for thumbstick -> button mapping #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-format is failing, please see https://github.com/Kenix3/libultraship/blob/main/CONTRIBUTING.md#running-clang-format |
Merged
|
Merged via #332 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When mapping thumbsticks to buttons the deadzones are ignored. There is an option
AxisMinimumPressto control the behaviour, but there is no UI option to actually modify it, so it's hardcoded as7680.0fand can only be changed by modifying the config JSON directly.Rather than making a new thumbstick UI with deadzones I figured it made sense to add a boolean checkbox that would allow you to apply your thumbstick deadzones for thumbstick -> button mapping.
I'm not really familiar with drawing UI in C++ so most of the options menu stuff is copied/pasted & modified from existing code. Please shout if it's wrong and let me know what to change 🙏