Add support for HD textures when loading textures for the GUI #334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had simple support for loading certain types of textures into ImGui directly to be able to render them for things like the item tracker/save editor. There was different logic for loading an rgba image vs a greyscale image.
However with HD textures, all images are in the rbga32 format (even greyscale images).
This makes it so we check the resource's flags to see if we should treat it as "raw" and load the texture data differently. For HD textures, the raw buffer is loaded similarly to how it is done in
gfx_pp.cpp
, albeit with less of the safety/size checking (I'm not sure how much of that needs to be done here).Tested with the OoT reloaded HD texture pack and confirmed that greyscale images like the song note textures are now rendering correctly.