Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change otr version check to still track game versions if available #346

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

Archez
Copy link
Contributor

@Archez Archez commented Sep 21, 2023

Previous PR #345 allowed OTR with no version to load, but accidentally broke game version tracking when there was a version file.

Tweaking the logic again to retain the game version tracking regardless of the valid version list, and still allow no version file to succeed when valid version list is empty.

  • OTR has no version && version list is empty -> continue to load the OTR
  • OTR has no version && version list is provided -> OTR is not loaded
  • OTR has version && version list is empty -> continue to load the OTR and track the game version
  • OTR has version && version list is provided -> only load OTR if its version matches the provided list and track the game version

Basically soh provides vanilla/mq and soh.otr files and an empty valid version list, but we still need the game versions tracked by the archive manager.

(sorry for the back-to-back on this, I should have fully tested all edge cases 😅)

@Kenix3 Kenix3 merged commit 6b32658 into Kenix3:main Sep 26, 2023
4 checks passed
@Archez Archez deleted the version-check-change-again branch September 26, 2023 03:51
KiritoDv pushed a commit to KiritoDv/libultraship that referenced this pull request Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants