change otr version check to still track game versions if available #346
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR #345 allowed OTR with no version to load, but accidentally broke game version tracking when there was a version file.
Tweaking the logic again to retain the game version tracking regardless of the valid version list, and still allow no version file to succeed when valid version list is empty.
Basically soh provides vanilla/mq and soh.otr files and an empty valid version list, but we still need the game versions tracked by the archive manager.
(sorry for the back-to-back on this, I should have fully tested all edge cases 😅)