Added simple gfx trace system #559
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add some ifdefs around all of this code and it can get in. |
briaguya-ai
reviewed
Aug 14, 2024
| displayList->Instructions.push_back(command); | ||
|
|
||
| uint8_t opcode = (uint8_t)(command.words.w0 >> 24); | ||
| int8_t opcode = (int8_t)(command.words.w0 >> 24); |
There was a problem hiding this comment.
this change from uint8_t to int8_t hiding in this PR feels a little scary to me. if using uint8_t here was a mistake i'd feel better having a separate PR fixing that so we can discuss that change, then this PR can focus solely on adding a feature.
There was a problem hiding this comment.
I think that was a mistake i did because i copy/paste some things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for debugging display lists to detect corruption or invalid data