Fix My Broken Implementation of G_QUAD for f3dex That Never Worked #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this PR has the same title as #599 i assume this is fixing something, would you mind updating the title/description to reflect what this is fixing? |
|
Looks like it's fixing (or just optimizing) how the quad is generated for the rendering api. |
MegaMech
changed the title
|
The arguments were not correct before and I was drawing too many triangles. Sorry, it was difficult to see if it was drawing correctly because the lighting doesn't work in the scene. But it's good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The args for G_QUAD to render quadrangles are correct now.