Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CC shader argument order for DirectX #636

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Fix CC shader argument order for DirectX #636

merged 1 commit into from
Jun 13, 2024

Conversation

Archez
Copy link
Contributor

@Archez Archez commented Jun 11, 2024

Fixes incorrect argument ordering from #628

MegaMech
MegaMech approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@MegaMech MegaMech left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this fixes a DX crash on launch

@Archez
Copy link
Contributor Author

Archez commented Jun 12, 2024

Windows build is failing due to incompatible build caches on the runners.

@briaguya-ai briaguya-ai merged commit fccf181 into Kenix3:main Jun 13, 2024
5 checks passed
@Archez Archez deleted the fix-cc-shader-args-dx branch June 14, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MegaMech MegaMech MegaMech approved these changes

@briaguya-ai briaguya-ai briaguya-ai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Archez @MegaMech @briaguya-ai