Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some warning #654

Merged
merged 8 commits into from
Oct 19, 2024
Merged

remove some warning #654

merged 8 commits into from
Oct 19, 2024

Conversation

coco875
Copy link
Contributor

@coco875 coco875 commented Aug 2, 2024

warning that I remove:

  • remove deplicate macro definition in controller.h.
  • avoid redefine _LANGUAGE_C.
  • only add -Wno-implicit-function-declaration when he compile for C or OBJC.
  • fix multiple useless typedef.
  • add attribute for some unused.
  • add cast for when it's not the same type of int (not fixing all).

@coco875
Copy link
Contributor Author

coco875 commented Aug 2, 2024

hmm how you want to add attribute macro ? for other os

@Kenix3
Copy link
Owner

Kenix3 commented Aug 14, 2024

hmm how you want to add attribute macro ? for other os

We don't really have a standard for this. Will need to do some research to see how it's handled in other projects.

@louist103
Copy link
Contributor

hmm how you want to add attribute macro ? for other os

[[maybe_unused]] and [[fallthrough]] are in C++ as of c++17 and should work on all platforms

@Kenix3
Copy link
Owner

Kenix3 commented Oct 10, 2024

hmm how you want to add attribute macro ? for other os

[[maybe_unused]] and [[fallthrough]] are in C++ as of c++17 and should work on all platforms

@coco875

@Kenix3 Kenix3 merged commit 9144f53 into Kenix3:main Oct 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants