Various warning fixes #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archez
commented
Aug 25, 2024
src/config/Config.cpp
Outdated
Comment on lines
139
to
145
| if (dots.size() > 1) { | ||
| int curDot = 0; | ||
| for (auto& dot : dots) { | ||
| if (gjson2.contains(dot)) { | ||
| if (curDot == dots.size()) { | ||
| if (dots.size() == 0) { | ||
| gjson2.erase(dot); | ||
| } else { | ||
| gjson2 = gjson2[dot]; |
There was a problem hiding this comment.
@Malkierian you added this method, so I just wanted to confirm with you that curDot was only ever meant to be 0 and that this change is fine. Otherwise did you mean for curDot to be re-assigned in this for-loop for some logic?
There was a problem hiding this comment.
Based on discord discussion, seems like this method is possibly incomplete and will be looked into in a follow up PR.
For now, I've reverted the change and only applied the signed int comparison fix to satisfy the warning.
Pepe20129
reviewed
Aug 25, 2024
Kenix3
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various warning fixes including:
warning: format not a string literal and no format arguments [-Wformat-security]warning: ‘typedef’ was ignored in this declarationwarning: ‘XYZ’ will be initialized after [-Wreorder]