Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Gfx Debugger for more OTR commands, UCODE support, and add context menu #668

Merged
merged 2 commits into from
Sep 14, 2024
Merged

Update Gfx Debugger for more OTR commands, UCODE support, and add context menu #668

merged 2 commits into from
Sep 14, 2024

Conversation

Archez
Copy link
Contributor

@Archez Archez commented Sep 3, 2024

This packs in a few updates for the Gfx Debugger with the following:

  • Support for all our custom OTR commands
  • A right click menu that allows easy clipboard copy for gfx instructions and scroll-to parent
  • Better support for different ucodes out of the box (not perfect, but better. Ideally it should track the loaded code at each gfx command)
  • Failsafe support in the case that the active frame buffer isn't reset back to the main game frame buffer (prevents ImGui soft locks)
image

github-actions[bot]
github-actions bot previously requested changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/5)

src/window/gui/GfxDebuggerWindow.h Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot previously requested changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (2/5)

src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot previously requested changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (3/5)

src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot previously requested changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (4/5)

src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot previously requested changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (5/5)

src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Outdated Show resolved Hide resolved
src/window/gui/GfxDebuggerWindow.cpp Show resolved Hide resolved
@github-actions github-actions bot dismissed stale reviews from themself September 3, 2024 15:33

No Clang-Tidy warnings found so I assume my comments were addressed

@Kenix3 Kenix3 merged commit da9e334 into Kenix3:main Sep 14, 2024
5 checks passed
@Archez Archez deleted the gfx-debugger-updates branch October 8, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Archez @Kenix3