Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REFACTOR] UserService 구현 포함, 전체 코드 리팩토링 #180
[REFACTOR] UserService 구현 포함, 전체 코드 리팩토링 #180
Changes from 17 commits
9ca26e1
8902f53
05b2def
92bc750
75b21c8
c49e271
25e1735
a15c914
58a413c
0db8e24
3432868
8da4f56
d949c16
e034c49
2b55700
946949b
0566ca7
7909ba1
cc07097
4319206
9d6d458
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p2: 소셜로그인만 제공할 예정인데 자체 가입 회원을 따로 둔 이유가 궁금
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
제거 완료
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이유는 리팩토링 하면서 아 그럼 여기 추가되면 되겠지 하고 넣은것 뿐이라, 빼겠습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p3: 사용자 검색 시 id로 이 컬럼을 사용한다면 unique index 거는 것이 좋다고 생각함.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
현재 닉네임은 중복이 발생함. 나중에 중복 발생 안되는 로직이 생기면 그때 유니크 거는게 좋다고 봄.