[FEAT] V2 패키지 구조 재설계 #258
Merged
[FEAT] V2 패키지 구조 재설계 #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangwonsheep
requested changes
Oct 17, 2024
Comment on lines
1
to
3
| package kernel360.techpick.feature.domain.rss.service.service; | ||
|
|
||
| public interface RssService { |
There was a problem hiding this comment.
p1: rss service 디렉토리 안에 dto, service 디렉토리가 추가로 더 생성되어 있음.
There was a problem hiding this comment.
rss/dto 안에 있는 클래스, rss/service/dto 안에 있는 클래스 중복
Comment on lines
+7
to
+13
| @Mapper( | ||
| componentModel = "spring", | ||
| injectionStrategy = InjectionStrategy.CONSTRUCTOR, | ||
| unmappedTargetPolicy = ReportingPolicy.ERROR | ||
| ) | ||
| public interface PickMapper { | ||
| } |
There was a problem hiding this comment.
p3: pickApiMapper, pickMapper가 따로 구분되어 있는데, 구분된 이유가 각 계층에서만 변환할 때 사용하는 것으로 이해하면 되는지?
There was a problem hiding this comment.
맞음. pickDtoMapper로 하는게 나을지 pickMapepr가 나을지 네이밍 고민됨. 의견 부탁
Gyaak
reviewed
Oct 17, 2024
backend/src/main/java/kernel360/techpick/feature/domain/user/dto/UserCommand.java
Show resolved
Hide resolved
backend/src/main/java/kernel360/techpick/feature/domain/user/dto/UserResult.java
Show resolved
Hide resolved
sangwonsheep
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? 🔍