[FEAT] pick v2 도메인 개발 #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimminkyeu
commented
Oct 20, 2024
| @OnDelete(action = OnDeleteAction.CASCADE) | ||
| @JoinColumn(name = "parent_folder_id", nullable = false) | ||
| private Folder parentFolder; | ||
|
|
||
| // 사용자가 수정 가능한 Pick 제목. 기본값은 원문 제목과 동일 | ||
| @Column(name = "title") // nullable | ||
| @Column(name = "title", nullable = false) | ||
| private String title; |
There was a problem hiding this comment.
String title = ""; 으로 수정 예정
Gyaak
requested changes
Oct 20, 2024
backend/src/main/java/kernel360/techpick/feature/infrastructure/folder/reader/FolderReader.java
Outdated
Show resolved
Hide resolved
Gyaak
requested changes
Oct 20, 2024
backend/src/main/java/kernel360/techpick/core/model/folder/Folder.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/kernel360/techpick/core/model/folder/Folder.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/kernel360/techpick/core/model/folder/Folder.java
Outdated
Show resolved
Hide resolved
|
PR이 너무 큰것같습니다.. infra쪽하고 service로직은 pr을 분리했어야 할거같아요.. |
Gyaak
reviewed
Oct 20, 2024
backend/src/main/java/kernel360/techpick/feature/domain/pick/service/PickServiceImpl.java
Outdated
Show resolved
Hide resolved
sangwonsheep
approved these changes
Oct 20, 2024
Comment on lines
+22
to
+23
| @Mapping(source = "pick.link", target = "linkInfo") | ||
| PickResult.Read toReadResult(Pick pick); |
There was a problem hiding this comment.
@Mapping에 대해 설명 가능한지?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR? 🔍