fix sine operations

force_feedback.c

@@ -17,7 +17,7 @@
 #define __set_bit(bit, field) {*(field) = *(field) | (1 << bit);}
 #define __clear_bit(bit, field) {*(field) = *(field) & ~(1 << bit);}
 
-#define sin16(in) (int16_t)(sin((double)(in) * (double)M_PI / 180.0))
+#define sin_deg(in) (double)(sin((double)(in) * (double)M_PI / 180.0))
 
 #define time_after_eq(a, b) (a >= b)
 #define time_before(a, b) (a < b)
@@ -117,7 +117,7 @@ static void lg4ff_update_state(struct lg4ff_effect_state *state, const uint64_t
 		if (!test_bit(FF_EFFECT_UPDATING, &state->flags)) {
 			state->updated_at = state->play_at;
 		}
-		state->direction_gain = sin16(effect->direction * 360 / 0x10000);
+		state->direction_gain = sin_deg(effect->direction * 360 / 0x10000);
 		if (effect->type == FF_PERIODIC) {
 			state->phase_adj = effect->u.periodic.phase * 360 / effect->u.periodic.period;
 		}
@@ -130,7 +130,7 @@ static void lg4ff_update_state(struct lg4ff_effect_state *state, const uint64_t
 	if (test_bit(FF_EFFECT_UPDATING, &state->flags)) {
 		__clear_bit(FF_EFFECT_PLAYING, &state->flags);
 		state->play_at = state->updated_at + effect->replay.delay;
-		state->direction_gain = sin16(effect->direction * 360 / 0x10000);
+		state->direction_gain = sin_deg(effect->direction * 360 / 0x10000);
 		if (effect->replay.length) {
 			state->stop_at = state->updated_at + effect->replay.length;
 		}
@@ -233,7 +233,7 @@ static int32_t lg4ff_calculate_periodic(struct lg4ff_effect_state *state)
 
 	switch (periodic->waveform) {
 		case FF_SINE:
-			level += sin16(state->phase) * magnitude;
+			level += sin_deg(state->phase) * magnitude;
 			break;
 		case FF_SQUARE:
 			level += (state->phase < 180 ? 1 : -1) * magnitude;

force_feedback.h

@@ -116,7 +116,7 @@ struct lg4ff_effect_state{
 	uint32_t cmd_start_count;
 	#endif
 
-	int32_t direction_gain;
+	double direction_gain;
 	int32_t slope;
 };