Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dark Souls 1-3 and Demon's Souls wiki entries #401

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

in1tiate
Copy link

Depends on #400. Addresses #236, #298, #299, #301, #302

Left off the Dark Souls fandom wikis, because they're consolidated under the Dark Souls 1 fandom wiki, meaning it's not possible to separate queries.
Also left off Bloodborne pending support for bloodborne-wiki.com's software.

Doesn't support wikis using third party search components like the SCP Wiki's Crom. Will need special support on a case-by-case basis
Also the Demon's Souls fandom wiki.
Left off the Dark Souls fandom wikis, because they're consolidated under the Dark Souls 1 fandom wiki, meaning it's not possible to separate queries
Also left off Bloodborne pending support for bloodborne-wiki.com's software.
@KevinPayravi
Copy link
Owner

Thanks for putting this (and #400) together!

From this post, it appears that Wikidot's search has been down for over a year now, so redirects using the search endpoint will not work. We could change destination_search_path from /search:site/q/ to /, so that IWB redirects attempt to take the user straight to the corresponding article instead of through the search. The downside is that if the article name doesn't match exactly, the user will reach a 404 on Wikidot...and since the search doesn't work, the user will have to do some digging to find the article they want.

The DS Wikidot subscriptions have also lapsed, so the wikis are locked from editing + no HTTPs :/

Based on the above I'm inclined to put this on-hold until at least search is available. I wonder if the DS Wiki owner can be reached to see if the subscription can be resumed, and if one of the alternative search solutions can be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants