fix(LEMS-2738): Convert Expression Editor Answer keys to strings #2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +49 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (1577d98) and published it to npm. You Example: yarn add @khanacademy/perseus@PR2042If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2042 |
anakaren-rojas
changed the title
anakaren-rojas
changed the title
anakaren-rojas
force-pushed
the
exercise-editor-fix
branch
from
73fa4c7 to
1577d98
Compare
catandthemachines
approved these changes
Dec 20, 2024
| @@ -565,6 +570,7 @@ class AnswerOption extends React.Component< | |||
|
|
|||
| handleImSure = () => { | |||
| this.props.onDelete(); | |||
| this.handleCancelDelete(); | |||
There was a problem hiding this comment.
Ooo, what's this do and why is it here?
There was a problem hiding this comment.
Its an existing function that closes the "I'm sure" button, I added it so it wouldn't stay open once someone deletes the current item
There was a problem hiding this comment.
Here is the before:
https://github.com/user-attachments/assets/8838f716-dfd4-4aa7-995d-b15f4c5aa22a
Here is the after:
Screen.Recording.2024-12-19.at.17.00.15.mov
Merged
anakaren-rojas
pushed a commit
that referenced
this pull request
Dec 20, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/perseus-editor@17.0.11 ### Patch Changes - [#2042](#2042) [`705d74b69`](705d74b) Thanks [@anakaren-rojas](https://github.com/anakaren-rojas)! - fix for editor Author: khan-actions-bot Reviewers: anakaren-rojas Required Reviewers: Approved By: anakaren-rojas Checks: ⏭️ Publish npm snapshot, ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x) Pull Request URL: #2051
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
onDeletehandler to use index instead of keyIssue: LEMS-2738
Test plan:
Screen.Recording.2024-12-19.at.16.18.48.mov