Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🔥AUDIT🔥] docs(changeset): Version bump to verify release protections #2045

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

somewhatabstract
Copy link
Member

🖍 This is an audit! 🖍

Summary:

In order to verify our existing release protection, that prevents snapshot releases from releasing non-snapshot versions, and to verify the additional workflow change in #2044 that should fail the snapshot release if a main release is in progress, we need a new release to kick off.

This PR bumps a patch version to make that happen.

Issue: XXX-XXXX

Test plan:

  1. [THIS PR] Audit a version bump and land that
  2. Wait for the Version Packages PR to be ready
  3. Merge Version Packages
  4. Immediately update my two PRs (docs(changeset): NOT LANDING THIS #2039 and Check for in progress releases before trying to do snapshots #2044) to match main and kickstart their actions
    • git pull && git merge --no-edit origin/main && git push && git switch snapshotsvsrelease.2 && git merge --no-edit origin/main && git push
  5. See what happens. With the fix, the script should error on pre-publish; and the new PR should fail the publish workflow - both should guard against the issue we saw.

If something doesn't prevent the publish, then a subsequent patch bump will be needed to correct that.

@somewhatabstract somewhatabstract self-assigned this Dec 19, 2024
@somewhatabstract somewhatabstract requested a review from a team December 19, 2024 23:06
Copy link
Contributor

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (ed640ca) and published it to npm. You
can install it using the tag PR2045.

Example:

yarn add @khanacademy/perseus@PR2045

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR2045

Copy link
Contributor

Size Change: 0 B

Total Size: 1.27 MB

ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 39 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 78 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-editor/dist/es/index.js 688 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/index.js 417 kB
packages/perseus/dist/es/strings.js 4.93 kB
packages/pure-markdown/dist/es/index.js 3.67 kB
packages/simple-markdown/dist/es/index.js 12.5 kB

compressed-size-action

@somewhatabstract somewhatabstract merged commit 57f9056 into main Dec 19, 2024
8 checks passed
@somewhatabstract somewhatabstract deleted the snapshotsvsrelease.test.bumpversions branch December 19, 2024 23:12
somewhatabstract added a commit that referenced this pull request Dec 19, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @khanacademy/perseus@49.1.4

### Patch Changes

- [#2045](#2045)
[`57f9056f8`](57f9056)
Thanks [@somewhatabstract](https://github.com/somewhatabstract)! -
Version bump to verify release protections

## @khanacademy/perseus-editor@17.0.8

### Patch Changes

- Updated dependencies
\[[`57f9056f8`](57f9056)]:
    -   @khanacademy/perseus@49.1.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant