Skip to content

Commit

Permalink
[πŸ”₯AUDITπŸ”₯] Run snapshots job when the PR is ready for review (#2095)
Browse files Browse the repository at this point in the history
πŸ– _This is an audit!_ πŸ–

## Summary:

The snapshot releases job only runs when the PR is not a draft. There was an
issue that prevented from creating a snapshot release when a PR was moved from
`draft` to `ready for review`.

This PR fixes that by including the `ready_for_review` activity type in the
workflow.

Issue: XXX-XXXX

## Test plan:

N/A

Author: jandrade

Auditors: nishasy

Required Reviewers:

Approved By: nishasy

Checks: ❌ codecov/project, βœ… Chromatic - Get results on regular PRs (ubuntu-latest, 16.x), βœ… Test (ubuntu-latest, 16.x, 2/2), βœ… Test (ubuntu-latest, 16.x, 1/2), βœ… Lint (ubuntu-latest, 16.x), βœ… Check build sizes (ubuntu-latest, 16.x), βœ… Chromatic - Build on regular PRs / chromatic (ubuntu-latest, 16.x), βœ… Publish npm snapshot (ubuntu-latest, 16.x), ⏭  Chromatic - Skip on Release PR (changesets), βœ… Check for .changeset entries for all changed files (ubuntu-latest, 16.x), ⏭  dependabot, βœ… gerald, βœ… Prime node_modules cache for primary configuration (ubuntu-latest, 16.x)

Pull Request URL: #2095
  • Loading branch information
jandrade authored Oct 20, 2023
1 parent 9489dde commit a9b02df
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .github/workflows/node-ci-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@ name: Node CI (PR)

on:
pull_request:
types: [edited, opened, synchronize, reopened]
# ready_for_review is useful for when a PR is converted from "draft" to "not
# draft".
types: [edited, opened, synchronize, ready_for_review, reopened]

# Our jobs run like this to minimize wasting resource cycles:
# 1. Prime caches for primary configuration (ubuntu on node 16).
Expand Down

0 comments on commit a9b02df

Please sign in to comment.