Verify changeset for every changed package #2071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
|
Size Change: 0 B Total Size: 89.9 kB ℹ️ View Unchanged
|
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-mlhrpggyia.chromatic.com/ Chromatic results:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2071 +/- ##
=======================================
Coverage 96.93% 96.93%
=======================================
Files 236 236
Lines 26651 26651
Branches 2356 2307 -49
=======================================
Hits 25835 25835
Misses 816 816 Continue to review full report in Codecov by Sentry.
|
jandrade
added a commit
that referenced
this pull request
Sep 28, 2023
## Summary: Now that we have a better path to release the packages in a safer way (#2070 and #2071), we can re-enable the snapshots release job. re-enable the snapshots release job to run on every non-draft PR. Issue: WB-1606 ## Test plan: Verify that the snapshots release job is running on every non-draft PR. Author: jandrade Reviewers: jeremywiebe, jeresig Required Reviewers: Approved By: jeremywiebe, jeresig Checks: ✅ codecov/project, ✅ Chromatic - Get results on non-draft regular PRs (ubuntu-latest, 16.x), ✅ Test (ubuntu-latest, 16.x, 2/2), ✅ Test (ubuntu-latest, 16.x, 1/2), ✅ Check build sizes (ubuntu-latest, 16.x), ✅ Lint (ubuntu-latest, 16.x), ✅ Chromatic - Build on non-draft regular PRs / chromatic (ubuntu-latest, 16.x), ⏭ Chromatic - Skip on Release PR (changesets), ✅ Publish npm snapshot (ubuntu-latest, 16.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 16.x), ✅ gerald, ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 16.x), ⏭ dependabot Pull Request URL: #2072
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Another implementation borrowed from the Perseus repo, that help us to verify
that there's a changeset for every changed package.
Previously, we were using
check-for-changesetto verify the existence of achangeset file, but now we switch to
changeset-per-packageto make sure thatthere's a changeset for every changed package. This is useful in monorepos like
this one.
See original PR: Khan/perseus#735 (thanks @nedredmond!)
Issue: XXX-XXXX
Test plan:
Verify that the CI passes and that in other PRs with actual changes, the
changeset workflow works as expected.