Accordion cleanup and release #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 358334d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2119 +/- ##
=======================================
Coverage 97.07% 97.07%
=======================================
Files 243 243
Lines 28238 28240 +2
Branches 2466 2420 -46
=======================================
+ Hits 27411 27413 +2
Misses 827 827
Continue to review full report in Codecov by Sentry.
|
|
Size Change: +7 B (0%) Total Size: 92.7 kB
ℹ️ View Unchanged
|
A new build was pushed to Chromatic! 🚀undefined Chromatic results:
|
…able, add changeset
…nt to be cut off when it wasn't in the last section of a rounded accordion
nishasy
changed the title
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (c8d86f5) and published all packages with changesets to npm. You can install the packages in webapp by running: ./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2119"Packages can also be installed manually by running: yarn add @khanacademy/wonder-blocks-<package-name>@PR2119 |
jandrade
approved these changes
Nov 16, 2023
🚀| "publishConfig": { | ||
| "access": "restricted" | ||
| "access": "public" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
All that's left is some polishing, and the Accordion component should be ready for launch!
In this PR:
Issue: https://khanacademy.atlassian.net/browse/WB-1585
Test plan:
yarn jestStorybook