Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the crash at double-freeing global #25

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Fixed the crash at double-freeing global #25

merged 1 commit into from
Jun 13, 2023

Conversation

Khhs167
Copy link
Owner

@Khhs167 Khhs167 commented Jun 13, 2023

I discovered this whist making #24, and decided to fix it.

It is just so that msfree(GLOBAL_MEMSTACK) doesn't crash memstack.

@Khhs167 Khhs167 requested a review from hrszpuk June 13, 2023 14:42
Copy link
Collaborator

@hrszpuk hrszpuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out on my local machine and seems to solve the issue. Nice catch 👍🏼.

@hrszpuk hrszpuk merged commit a86d108 into master Jun 13, 2023
@Khhs167 Khhs167 mentioned this pull request Jun 13, 2023
@Khhs167 Khhs167 deleted the global-fix branch June 13, 2023 18:12
@Khhs167 Khhs167 added this to the Next Release(1.3.0/1.2.1) milestone Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants