Update asciidoctor-spec image to ruby:3.3.3 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This greatly reduces the number of CVEs reported by Dockerhub and also updates the toolchain to current versions of asciidoctor (which apparently gives some better error messages now than it used to). Because of the underlying Debian updates, Python packages can no longer be installed at system level without a very ugly and brute-force override. Instead this image sets up a Python virtual environment containing all the packages, with just enough of an OS-level Python to install venv itself. If you are following the image instructions to do your own non-Docker install of the toolchain, you will need to setup a venv and then use the 'activate' script or otherwise setup your VIRTUAL_ENV and PATH to use that version. Scripts relying on Python packages installed by this image must invoke the python3 in the venv, not /usr/bin/python3.
|
@rpavlik headsup for you if updating to a newer base image about the Debian / Python system package install restriction change, that might affect your Dockerfiles as well. |
|
SYCL has KhronosGroup/SYCL-Docs#576 queued up to use the updated image and migrate to specifying by SHA instead of just by name, and I have a comparable internal MR that will go out soon for Vulkan-Docs and have verified Actions works with the image, so calling this good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This greatly reduces the number of CVEs reported by Dockerhub and also updates the toolchain to current versions of asciidoctor (which apparently gives some better error messages now than it used to).
Because of the underlying Debian updates, Python packages can no longer be installed at system level without a very ugly and brute-force override. Instead this image sets up a Python virtual environment containing all the packages, with just enough of an OS-level Python to install venv itself. If you are following the image instructions to do your own non-Docker install of the toolchain, you will need to setup a venv and then use the 'activate' script or otherwise setup your VIRTUAL_ENV and PATH to use that version. Scripts relying on Python packages installed by this image must invoke the python3 in the venv, not /usr/bin/python3.