Fixing vendor-specific/tied memory property flag detection #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit d9fca6e)
|
Dear @MarkCallow , this should fix the reported issue. Though would appreciate a quick smoke test on the M2 device as well just to be sure. |
It works. |
MarkCallow
requested changes
Sep 17, 2023
|
For orthogonality please add `ktxTexture[12]_VkUploadEx_WithSuballocator wrappers to vkloader.c. I hadn't noticed they weren't there in the previous PR. |
All done! Let me know if this suffices. 🙏 |
MarkCallow
approved these changes
Sep 17, 2023
|
Thanks again. |
You're very welcome Mark. I feel privileged to have been able to contribute. |
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 21, 2024
…#771) * Add ktxTexture1/2 wrappers as well.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
…#771) * Add ktxTexture1/2 wrappers as well.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
…#771) * Add ktxTexture1/2 wrappers as well.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
…#771) * Add ktxTexture1/2 wrappers as well.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
…#771) * Add ktxTexture1/2 wrappers as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing vendor-specific/tied memory property flag detection for
vkloadtests's VMA wrapper.