Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KTXwriterScParams support #779

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

aqnuep
Copy link
Collaborator

@aqnuep aqnuep commented Oct 2, 2023

Fixes #758.

Depends on the CTS PR KhronosGroup/KTX-Software-CTS#5.

@MarkCallow FYI (please make sure you merge the CTS PR first with rebasing policy).

@aqnuep aqnuep marked this pull request as ready for review October 2, 2023 16:10
@MarkCallow
Copy link
Collaborator

Please rebase to get the MinGW fix.

Looks good but the repetition of so many string values is unfortunate. Is there a way to reduce the repetition? If not, please define a const string object for each value and refer to that at each place where needed.

@aqnuep
Copy link
Collaborator Author

aqnuep commented Oct 4, 2023

Please rebase to get the MinGW fix.

Looks good but the repetition of so many string values is unfortunate. Is there a way to reduce the repetition? If not, please define a const string object for each value and refer to that at each place where needed.

Yeah, I tried to minimize that, in fact eliminated one of them. We could use some consts, sure.

@MarkCallow
Copy link
Collaborator

MarkCallow commented Oct 4, 2023

Yeah, I tried to minimize that, in fact eliminated one of them. We could use some consts, sure.

Please do it.

Note that my e-mail service is currently broken. I can neither send nor receive messages from my regular addresses. Therefore my responses may be somewhat delayed.

@aqnuep
Copy link
Collaborator Author

aqnuep commented Oct 4, 2023

I've rebased and added string constants for all the places where it made sense. This should be fine once CI passes.

I can neither send nor receive messages from my regular addresses.

Is there any channel through which we can contact you privately in the meantime?

@MarkCallow
Copy link
Collaborator

Is there any channel through which we can contact you privately in the meantime?

I've just sent you a message from it.

@aqnuep aqnuep marked this pull request as draft October 4, 2023 11:03
@aqnuep aqnuep marked this pull request as ready for review October 4, 2023 11:19
@aqnuep
Copy link
Collaborator Author

aqnuep commented Oct 4, 2023

Removed "astc-mode" option, as requested. Instead, default to LDR mode for UNORM/SRGB.

@aqnuep
Copy link
Collaborator Author

aqnuep commented Oct 5, 2023

Updated CTS git submodule hash. Ready for merge.

@MarkCallow MarkCallow merged commit f8691ff into KhronosGroup:main Oct 5, 2023
14 checks passed
@aqnuep aqnuep deleted the writerScParams-support branch October 12, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No ktx tool writes KTXwriterScParams metadata.
2 participants