Jnipp fixes #285
Closed
Jnipp fixes #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the local thread attached the current thread to the VM outside of this system it is possible that _env is null AND IsAttached returns true. If _env is null yet the thread is attached, use the environment as given by GetEnv.
|
Thanks for this! I actually had just gotten essentially this patch submitted to Monado, but based on and including a few other small fixes https://gitlab.freedesktop.org/monado/monado/-/merge_requests/1032 I'll close this PR but will reference it in the changelog fragment for the one I submitted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing JNI null de-reference crash.