Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Fix typo in declspec keyword #302

Merged
merged 3 commits into from
May 26, 2022
Merged

tests: Fix typo in declspec keyword #302

merged 3 commits into from
May 26, 2022

Conversation

Biswa96
Copy link
Contributor

@Biswa96 Biswa96 commented Apr 9, 2022

This fixes the following errors with mingw toolchain.

OpenXR-SDK-Source/src/tests/hello_xr/main.cpp:17:10: error: expected constructor, destructor, or type conversion before '(' token
   17 | _declspec(dllexport) DWORD NvOptimusEnablement = 0x00000001;
      |          ^
OpenXR-SDK-Source/src/tests/hello_xr/main.cpp:19:10: error: expected constructor, destructor, or type conversion before '(' token
   19 | _declspec(dllexport) DWORD AmdPowerXpressRequestHighPerformance = 0x00000001;
      |          ^

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2022

CLA assistant check
All committers have signed the CLA.

@Biswa96
Copy link
Contributor Author

Biswa96 commented Apr 9, 2022

I am not sure what I should do with the CLA check. I have signed CLA in other vulkan repositories without any issue.

@rpavlik-bot
Copy link
Collaborator

An issue (number 1691) has been filed to correspond to this pull request in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#1691 ), to facilitate working group processes.

This GitHub pull request will continue to be the main site of discussion.

@rpavlik-bot rpavlik-bot added the synced to gitlab Synchronized to OpenXR internal GitLab label Apr 14, 2022
@rpavlik
Copy link
Contributor

rpavlik commented May 26, 2022

There are two CLAs depending on whether the repo is mostly spec text, or mixed spec and code. (or it might be per repo? I don't remember) @KhronosWebservices ?

Good catch, sorry I didn't notice it until now. You should be able to rebase on main and the CI will work again.

Can you add a changelog fragment called changes/sdk/pr.302.gh.OpenXR-SDK-Source.md with a brief description? (in this case, your subject line for the PR is perfect) This one is easy enough I can do it myself later, it's just nice to get folks in the habit.

@rpavlik
Copy link
Contributor

rpavlik commented May 26, 2022

OK that status literally updated while I was editing my comment, looks like your CLA is good to go now.

Biswa96 and others added 3 commits May 26, 2022 14:02
This fixes the following errors with mingw toolchain.
OpenXR-SDK-Source/src/tests/hello_xr/main.cpp:17:10: error: expected constructor, destructor, or type conversion before '(' token
   17 | _declspec(dllexport) DWORD NvOptimusEnablement = 0x00000001;
      |          ^
OpenXR-SDK-Source/src/tests/hello_xr/main.cpp:19:10: error: expected constructor, destructor, or type conversion before '(' token
   19 | _declspec(dllexport) DWORD AmdPowerXpressRequestHighPerformance = 0x00000001;
      |          ^
Copy link
Contributor

@rpavlik rpavlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing this!

@KhronosWebservices
Copy link

cla-assistant can be slow if experiencing a heavy load. This repository is using the Apache 2.0 CLA.

@rpavlik rpavlik merged commit c00a2d9 into KhronosGroup:main May 26, 2022
@Biswa96 Biswa96 deleted the declspec-typo branch May 27, 2022 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
synced to gitlab Synchronized to OpenXR internal GitLab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants