add macOS define #323
add macOS define #323
Conversation
This fixes building the loader on macOS. With this commit I am able to build the loader on macOS as part of the [openxr rust crate](https://github.com/Ralith/openxrs). I have a fork of [hotham-simulator](https://github.com/leetvr/hotham/wiki/Adding-the-Hotham-Simulator-to-your-development-environment) working locally, allowing complete (albeit basic) openXR development locally on my macbook.
|
|
|
Great, thanks! Can you make a changelog fragment changes/sdk/pr.323.gh.OpenXR-SDK-Source.md too? The readme there has more advice. |
rpavlik
added
the
needs changelog fragment
Just added a changelog fragment (hope I did it correctly). |
|
Friendly bump @rpavlik, thanks again for taking a look! |
|
Yeah I have to figure out what's wrong with CI, I'll get to it when I'm in the office again. |
|
It looks like you might somehow have a trailing space on that filename for your changelog file? I didn't know that was possible but that's what it looks like. |
Wow you're right, I had no idea that was possible either 😅 Looks like it's fixed now |
fixes macOS build with KhronosGroup/OpenXR-SDK-Source#323
fixes macOS build with KhronosGroup/OpenXR-SDK-Source#323
This fixes building the loader on macOS.
With this commit I am able to build the loader on macOS as part of the openxr rust crate. I also have a fork of hotham-simulator working locally, allowing complete (albeit basic) openXR development locally on my macbook.