c: allow access to gl_plain_uniforms resources #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -226,6 +226,7 @@ typedef enum spvc_resource_type | |||
| SPVC_RESOURCE_TYPE_ACCELERATION_STRUCTURE = 12, | |||
| SPVC_RESOURCE_TYPE_RAY_QUERY = 13, | |||
| SPVC_RESOURCE_TYPE_SHADER_RECORD_BUFFER = 14, | |||
| SPVC_RESOURCE_TYPE_GL_PLAIN_UNIFORM = 15, | |||
There was a problem hiding this comment.
You need to bump SPVC_C_API_VERSION_MINOR, as well as spirv-cross-abi-minor in CMakeLists.txt when you add anything backwards compatible to the headers.
HansKristian-Work
requested changes
Sep 2, 2024
chyyran
force-pushed
the
c_gl_plain_uniforms
branch
from
f895458
to
b2171de
Compare
|
Bumped C minor ABI version to 63 in b2171de |
HansKristian-Work
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2369