-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spirv-val: Add Vulkan Image Format check #5458
base: main
Are you sure you want to change the base?
spirv-val: Add Vulkan Image Format check #5458
Conversation
There are several glslang unit test failures. The sparse failures look like a spec problem. Sparse samples return a struct with residency and value. The zero/sign extend should apply to the second element. The image write case is a similar problem, spec says result type, but there is no result type. I'm unsure about the HLSL test. It looks incorrect to me, but I'm not sure what the strategy for specifying formats is when compiling HLSL. |
See Khronos internal issue 766. |
with https://gitlab.khronos.org/spirv/SPIR-V/-/merge_requests/302 merged, will apply and rebase |
Second attempt at #4748
checks for
VUID-StandaloneSpirv-Image-04965