Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor corrections and tweaks #403

Merged
merged 6 commits into from
Apr 27, 2023

Conversation

nmnobre
Copy link
Contributor

@nmnobre nmnobre commented Apr 25, 2023

Hi,

This is just a slate of minor fixes I compiled while reading. :-)

Cheers,
-Nuno

@CLAassistant
Copy link

CLAassistant commented Apr 25, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@gmlueck gmlueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think you missed one, though. :-)

The concept of a <<group>> of <<work-item,work items>> was generalized to include
<<work-group,work groups>> and <<sub-group,sub groups>>. A <<work-group>> is represented
The concept of a <<group>> of <<work-item,work-items>> was generalized to include
<<work-group,work-groups>> and <<sub-group,sub groups>>. A <<work-group>> is represented
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<<work-group,work-groups>> and <<sub-group,sub groups>>. A <<work-group>> is represented
<<work-group,work-groups>> and <<sub-group,sub-groups>>. A <<work-group>> is represented

Since you are adding hyphens to this line anyway, let's add this one too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grand. Thanks!

Copy link
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continue reading like that and bring your friends too. :-)
Thanks.

@fraggamuffin
Copy link

RK to approve .
LGTM

@keryell keryell merged commit 7ef6968 into KhronosGroup:SYCL-2020/master Apr 27, 2023
keryell added a commit that referenced this pull request Sep 10, 2024
Fix some wording for work-groups, work-items & sub-groups.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants