Explicit VU for Uniform being read only #1879
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the SPIR-V spec,
Uniform
are not defined as read-only (UniformConstant
are) andspirv-val
does validate this, but it is missing an explicit VUID and language in the Vulkan specAlso combines the 2 VUs talking about which opaque types are read-only to a single VUID
(no need to change the VUID as neither
04661
or04665
are currently being validated yet KhronosGroup/SPIRV-Tools#4796)