Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vulkan-framework #1397

Closed
wants to merge 1 commit into from
Closed

Remove vulkan-framework #1397

wants to merge 1 commit into from

Conversation

juan-lunarg
Copy link
Contributor

Per https://gitlab.khronos.org/vulkan/Vulkan-SDK-Packaging/-/issues/1317#note_442996

This removes duplicate headers in the MacOS SDK installation.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build queued with queue ID 92862.

@juan-lunarg
Copy link
Contributor Author

Now Mac installation looks like this:

juanramos@Juans-MBP loader % cmake --install build --prefix /tmp                        
-- Install configuration: "Debug"
-- Up-to-date: /tmp/lib/libvulkan.1.3.0.dylib
-- Up-to-date: /tmp/lib/libvulkan.1.dylib
-- Up-to-date: /tmp/lib/libvulkan.dylib
-- Up-to-date: /tmp/lib/cmake/VulkanLoader/VulkanLoaderConfig.cmake
-- Up-to-date: /tmp/lib/cmake/VulkanLoader/VulkanLoaderConfig-debug.cmake
-- Up-to-date: /tmp/lib/pkgconfig/vulkan.pc

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 2381 running.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 2381 passed.

@richard-lunarg
Copy link
Contributor

We can't remove this yet. We are putting a deprecation notice in the January SDK that it will be removed in the future. Early next year, we can go ahead and remove it.

@juan-lunarg
Copy link
Contributor Author

Closing for now.

@juan-lunarg juan-lunarg closed this Dec 1, 2023
@juan-lunarg juan-lunarg deleted the juan/remove_vulkan-framework branch December 1, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants