Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to pull-request template and assets submodule #1

Merged
merged 3 commits into from
Nov 8, 2019

Conversation

JoseEmilio-ARM
Copy link
Collaborator

@JoseEmilio-ARM JoseEmilio-ARM commented Nov 2, 2019

Pull Request Template

Description

Fix link to wiki in CONTRIBUTING.md
In the pull-request template:

  • Removed Copyright notice
  • Fixed typo ('=' should be '-')
  • Fixed links to other files

Updated assets SHA to point to latest master

Checklist:

  • n/a My code follows the coding style
  • n/a I have performed a self-review of my own code
  • n/a I have commented my code, particularly in hard-to-understand areas
  • n/a I have made corresponding changes to the documentation
  • n/a I have tested my sample on at least one compliant Vulkan implementation
  • n/a I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • n/a My changes do not add any new compiler warnings
  • n/a Vulkan validation layer output is clean on at least one compliant implementation
  • n/a Any dependent changes (e.g. assets) have been merged and published in downstream modules
  • n/a I have used existing framework/helper functions where possible
  • I have reviewed file licenses
  • n/a My changes build and run on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

@JoseEmilio-ARM JoseEmilio-ARM changed the title Update contribution guide link to review process Updates to contribution guide and assets submodule Nov 8, 2019
@JoseEmilio-ARM JoseEmilio-ARM requested review from a user and wasimabbas-arm November 8, 2019 09:56
@JoseEmilio-ARM JoseEmilio-ARM changed the title Updates to contribution guide and assets submodule Updates to pull-request template and assets submodule Nov 8, 2019
@ghost
Copy link

ghost commented Nov 8, 2019

I am not seeing check boxes, I guess that is just a bug.

What about those templates that we're mentioned, should we be using those?

@JoseEmilio-ARM
Copy link
Collaborator Author

I am not seeing check boxes, I guess that is just a bug.

What about those templates that we're mentioned, should we be using those?

I think we are already using the templates that you are referring to. In this case I replaced the checkboxes with 'n/a' since this is a small documentation change, no source code was added/modified.

@wasimabbas-arm wasimabbas-arm merged commit 4759391 into KhronosGroup:master Nov 8, 2019
@gary-sweet gary-sweet mentioned this pull request Apr 8, 2020
12 tasks
gpx1000 referenced this pull request in gpx1000/Vulkan-Samples Aug 4, 2021
Fixed a few warnings and spelling errors.

Approved-by: William Lohry
marty-johnson59 pushed a commit that referenced this pull request Mar 13, 2023
* logic_op_dynamic_state sample (#1)

* Fix readme comment (#2)

* Fix validation layers errors (#3)

* Fixes after review (#4)
marty-johnson59 pushed a commit that referenced this pull request Dec 9, 2024
… vkb::allocated::Allocated<bindingType> (#1193)

* Unify vkb::allocated::Allocated and vkb::allocated::HPPAllocated into vkb::allocated::Allocated<bindingType>

* Adding documentation to the allocated class hierarchy, base classes edition (#1)

* Adding documentation to the allocated class hierarchy, base classes edition

* fixup! Adding documentation to the allocated class hierarchy, base classes edition

* fixup! Adding documentation to the allocated class hierarchy, base classes edition

* fixup! fixup! Adding documentation to the allocated class hierarchy, base classes edition

* Fix formatting and doxygen issue.

* Unify vkb::allocated::Allocated and vkb::allocated::HPPAllocated into vkb::allocated::Allocated<bindingType>

* Adding documentation to the allocated class hierarchy, base classes edition (#1)

* Adding documentation to the allocated class hierarchy, base classes edition

* fixup! Adding documentation to the allocated class hierarchy, base classes edition

* fixup! Adding documentation to the allocated class hierarchy, base classes edition

* fixup! fixup! Adding documentation to the allocated class hierarchy, base classes edition

* Fix formatting and doxygen issue.

---------

Co-authored-by: Bradley Austin Davis <bdavis@saintandreas.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants