Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VK_Video #1245

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

VK_Video #1245

wants to merge 20 commits into from

Conversation

gpx1000
Copy link
Collaborator

@gpx1000 gpx1000 commented Dec 12, 2024

Description

This is a sample showing how to use Vulkan Video. Developer's MUST have FFMPEG development libraries installed. FFMPEG is used for demuxing duties only. This sample attempts to make a generic library out of the NVIDIA Vulkan Video Sample to show how it can be used in a more generic way. As this is a very complex sample, it likely will take many revisions before landing.

NB: Vulkan Video is only supported in desktop environments. Also, it isn't required to ultimately use FFMPEG, one can use things like https://github.com/lieff/minimp4 or similar to handle the demuxing. However; that would only support h264 while FFMPEG is well tested and supports all codecs. Working on a demuxing solution is beyond the scope of this sample; but it is possible to do.

Tested in Linux on NVIDIA hardware.

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

  • I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
  • For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
  • For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

gpx1000 and others added 20 commits December 5, 2022 15:23
# Conflicts:
#	samples/extensions/video/CMakeLists.txt
#	samples/extensions/video/VideoProcessor.cpp
#	samples/extensions/video/VideoProcessor.h
Replaced obsolete `VideoProcessor` implementation with new Vulkan-based components for video encoding and decoding. Added `VulkanBitstreamBufferImpl`, `VulkanDescriptorSetLayout`, and related utilities that enhance functionality, maintainability, and performance.
Refreshed the assets folder with updated files to align with recent changes. This ensures consistency and accuracy across related resources.
This README provides an in-depth overview of the Vulkan Video sample, detailing its usage, configuration, and dependencies (e.g., FFMPEG). It also explains video decoding processes, supported codecs (e.g., H.264), and integration with Vulkan objects, helping developers implement GPU-accelerated video decoding effectively.
@SaschaWillems
Copy link
Collaborator

Haven't had time to do a proper review yet, but it looks like this PR downgrades the asset submodule to a very old version, which would remove several assets used by some of the recent examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants