Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new sample - dynamic line rasterization #790

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

Krzysztof-Dmitruk-Mobica
Copy link
Contributor

Description

This pull request proposes a sample that demonstrates methods for dynamically customizing the appearance of rendered lines.

Notes

Tested on:

Ubuntu 23.04
Intel i7-11800H
Intel TigerLake-H GT1/Nvidia T600 Mobile
32 GB RAM

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the samples readme
  • For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering

Copy link
Collaborator

@SaschaWillems SaschaWillems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this great sample! Code and sample look fine to me and work as expected on my setup (Win11 + RTX 2060).

I only have a minor request: Can you add a screenshot of the sample to the readme?

@Krzysztof-Dmitruk-Mobica
Copy link
Contributor Author

Sure! I've added a screenshot.

Copy link
Contributor

@asuessenbach asuessenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides one minor issue (three times), it's a great example!

@gary-sweet
Copy link
Contributor

Unfortunately I can't test this. My hardware doesn't support stippled lines or dynamic polygon mode.

It would be great if the sample could check the support for each feature and just not use any that weren't supported rather than requiring everything in order to run anything.

@marty-johnson59 marty-johnson59 merged commit 23d9748 into KhronosGroup:main Sep 11, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants