-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new sample - dynamic line rasterization #790
Add a new sample - dynamic line rasterization #790
Conversation
98f8dbc
to
954bbf8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for this great sample! Code and sample look fine to me and work as expected on my setup (Win11 + RTX 2060).
I only have a minor request: Can you add a screenshot of the sample to the readme?
Sure! I've added a screenshot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides one minor issue (three times), it's a great example!
samples/extensions/dynamic_line_rasterization/dynamic_line_rasterization.cpp
Outdated
Show resolved
Hide resolved
samples/extensions/dynamic_line_rasterization/dynamic_line_rasterization.cpp
Outdated
Show resolved
Hide resolved
samples/extensions/dynamic_line_rasterization/dynamic_line_rasterization.cpp
Outdated
Show resolved
Hide resolved
0588607
to
057fec6
Compare
Unfortunately I can't test this. My hardware doesn't support stippled lines or dynamic polygon mode. It would be great if the sample could check the support for each feature and just not use any that weren't supported rather than requiring everything in order to run anything. |
Description
This pull request proposes a sample that demonstrates methods for dynamically customizing the appearance of rendered lines.
Notes
Tested on:
Ubuntu 23.04
Intel i7-11800H
Intel TigerLake-H GT1/Nvidia T600 Mobile
32 GB RAM
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
Sample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: