Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dynamic_blending sample to work in more cases #825

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

gary-sweet
Copy link
Contributor

Description

Allow dynamic_blending sample to work on more hardware.
Feature support is checked and functionality reduced where applicable rather than just not running.
This now runs on my hardware (which doesn't support dynamic advanced blending changes).

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. (Tested only on Linux)

Feature support is checked and functionality reduced
where applicable rather than just not running.
asuessenbach
asuessenbach previously approved these changes Oct 18, 2023
Copy link
Contributor

@asuessenbach asuessenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if that's a valid test, but when I force eds_feature_support.extendedDynamicState3ColorWriteMask to be VK_FALSE (and keep the other flags on VK_TRUE), I get this validation layer error in build_command_buffer_for_plane:
Validation Error: [ VUID-vkCmdSetColorWriteMaskEXT-None-08540 ] Object 0: handle = 0x21a0ed66450, type = VK_OBJECT_TYPE_COMMAND_BUFFER; | MessageID = 0x4adab21f | vkCmdSetColorWriteMaskEXT(): extendedDynamicState3ColorWriteMask or shaderObject feature is not enabled. The Vulkan spec states: Either the extendedDynamicState3ColorWriteMask feature or the shaderObject feature or both must be enabled (https://vulkan.lunarg.com/doc/view/1.3.250.1/windows/1.3-extensions/vkspec.html#VUID-vkCmdSetColorWriteMaskEXT-None-08540)

@gary-sweet
Copy link
Contributor Author

Good catch. I've added the missing guard around that now.

@marty-johnson59 marty-johnson59 merged commit b9f560f into KhronosGroup:main Nov 6, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants