Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEBGL_multi_draw] Align with Web IDL specification #3164

Closed
wants to merge 10 commits into from

Conversation

autokagami
Copy link

@autokagami autokagami commented Oct 18, 2020

🤖 This is an automated pull request to align the spec with the latest Web IDL specification. 🤖

The followings are the Web IDL validation messages, which may help understanding this PR:

  • Validation error at line 3 in WEBGL_multi_draw,0, inside `interface WEBGL_multi_draw -> extended-attribute NoInterfaceObject`:
    [NoInterfaceObject]
     ^
    

    Error: [NoInterfaceObject] extended attribute is a legacy feature that is now renamed to [LegacyNoInterfaceObject]. Refer to the relevant upstream PR for more information.

  • Validation error at line 4 in WEBGL_multi_draw,0, inside `interface WEBGL_multi_draw`:
    interface WEBGL_multi_draw {
              ^
    

    Error: Interfaces must have [Exposed] extended attribute. To fix, add, for example, [Exposed=Window]. Please also consider carefully if your interface should also be exposed in a Worker scope. Refer to the WebIDL spec section on Exposed for more information.

Currently this autofix might introduce awkward code formatting, and feel free to manually fix it whenever it happens.

Please file an issue at https://github.com/saschanaz/webidl-updater/issues/new if you think this is invalid or should be enhanced.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kenrussell
Copy link
Member

Looks like this one might still need to be handled @jdashg .

@foolip
Copy link

foolip commented Apr 13, 2021

@kenrussell @jdashg this is one of many open PRs like this, https://github.com/KhronosGroup/WebGL/pulls?q=is%3Apr+is%3Aopen+nointerfaceobject is the full list.

Is there something that needs to be done to make it possible to merge all of these?

cc @saschanaz

@kdashg
Copy link
Contributor

kdashg commented Apr 15, 2021

This will be handled by #3279.
We can't accept Contributions without a signed CLA, as the CLA bot has stated in each of these PRs.
It's easy enough to do these changes ourselves, but we can't take Contributions from CLA. Someone has to be responsible for it.

@saschanaz
Copy link
Contributor

WHATWG special cased this bot; could we do the same here? I can sign it with my name, though.

@kdashg
Copy link
Contributor

kdashg commented Apr 15, 2021

@outofcontrol ^

@outofcontrol
Copy link
Contributor

If we whitelist @autokagami in the CLA, who does liability fall to in case of a dispute in the code?

@saschanaz
Copy link
Contributor

Theoretically the bot cannot write any disputable code since changes from the bot never affects any behavior or API form. What's the policy for such changes?

@kdashg
Copy link
Contributor

kdashg commented Apr 16, 2021

Basically the bot needs a human to take responsibility for it, which includes being responsible for any mistakes. (even though it's not supposed to do anything Bad!)
If you can sign the CLA for the bot, @saschanaz, I think that's clearest here.

@saschanaz
Copy link
Contributor

I can do that, but kinda hoped there is a way to mark a PR as non-substantive as w3c ash-nazg does 🤔

@outofcontrol
Copy link
Contributor

This question has been run up the legal flag pole for review. Will post back here once we have an answer.

@kenrussell
Copy link
Member

Handled in #3279 .

@kenrussell kenrussell closed this Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants