Allow either bad-size=>INVALID_OP or bad-stride=>INVALID_VAL for vert… #3269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenrussell
approved these changes
Apr 6, 2021
There was a problem hiding this comment.
Sorry for the delay reviewing; had to revisit all the associated specs.
Just to clarify my understanding, is the problem with this particular test that both the size and stride are illegal, so it's ambiguous which one's validation causes the error (and the error differs depending on which one failed validation)?
|
That's right, though even this subtest's stated goal is to test too-large stride, which we spec'd in webgl to be INVALID_VALUE. |
|
I see - thanks for clarifying. Had a hard time finding again the too-large stride spec. Adjusted your message above to point to the two spec sections. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…exAttribPointer.
Bad size is specified as INVALID_OPERATION here:
https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.10
Too-large stride is specified as INVALID_VALUE here:
https://www.khronos.org/registry/webgl/specs/latest/1.0/#6.13