-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add drawingBufferColorSpace/unpackColorSpace attributes to WebGLRenderingContextBase. #3292
Conversation
Define its behavior both for presenting the rendering context's results, and uploading textures via texImage2D / texSubImage2D from DOM inputs (the TexImageSource union type). Follows whatwg/html#6562 , in which the PredefinedColorSpace enum was defined, and its behavior for 2D canvas contexts specified.
@jdashg @ccameron-chromium @RafaelCintron in particular (active participants in the ColorWeb CG), please take a look. |
context is uploaded or drawn to another one.
Reallocate drawing buffer when drawingBufferColorSpace is changed.
For ease of use, we should consider taking a context creation attrib for colorSpace, and filling these attribs in from that initial value. We should probably exclude it from getContextAttributes, though, since those are immutable results. |
That SGTM. |
Make unpackColorSpace apply to ImageBitmaps and add rationale.
@kdashg @ccameron-chromium sounds fine; let's do that in a follow-up since we have agreement on the rest of this PR at the moment. |
All conversations resolved, and approved - squashing and merging. |
…nts-and-properties (#3408) Follow-on to #3292 . Related to https://crbug.com/1208480 .
Follow-on to #3408 and #3292 . Related to https://crbug.com/1208480 .
Define their behavior both for presenting the rendering context's
results, and uploading textures via texImage2D / texSubImage2D from
DOM inputs (the TexImageSource union type).
Follows whatwg/html#6562 , in which the
PredefinedColorSpace enum was defined, and its behavior for 2D canvas
contexts specified.