-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial submit of WEBGL_multisampled_render_to_texture proposal #3342
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution. A few issues to be addressed.
@@ -0,0 +1,160 @@ | |||
<?xml version="1.0"?> | |||
|
|||
<extension href="WEBGL_multisampled_render_to_texture/"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run "make" under the extensions/
directory and fix the errors generated. At least this href is incorrect; there may be others.
"use strict"; | ||
|
||
let wtu = WebGLTestUtils; | ||
let gl = wtu.create3DContext(null, null, 2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the extension is written against the WebGL 1.0 specification, this test should be placed in conformance/extensions/
rather than conformance2/extensions/
. In that case the create3DContext
call should not specify a context version as its third argument.
@@ -0,0 +1,181 @@ | |||
<!-- | |||
Copyright (c) 2019 The Khronos Group Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2021
@@ -0,0 +1,181 @@ | |||
<!-- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add any new tests to 00_test_list.txt
in the same directory.
For WebGL 1.0 tests, use --min-version 1.0.4
.
For WebGL 2.0 tests, use --min-version 2.0.1
.
I would prefer not to add more WebGL 1 extensions anymore, now that all UAs have WebGL2. (And any machine that we support this ext on would support webgl2) |
Used for occulus quest and pico devices. KhronosGroup/WebGL#3342
No description provided.