Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move renderbuffer format extensions to draft; add tests #3575

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Move renderbuffer format extensions to draft; add tests #3575

merged 1 commit into from
Aug 1, 2023

Conversation

lexaknyazev
Copy link
Member

No description provided.

kenrussell
kenrussell approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@kenrussell kenrussell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Nice work on the tests in particular - they were easy to read. One tiny typo in a comment. Let me know whether you'd like to fix now. If you have permission to squash&merge, feel free to do that afterward.

sdk/tests/conformance2/extensions/ext-render-snorm.html Outdated Show resolved Hide resolved
@kenrussell
Copy link
Member

Thanks.

@kenrussell kenrussell merged commit f4c305f into KhronosGroup:main Aug 1, 2023
1 check passed
@lexaknyazev lexaknyazev deleted the draft-render-formats branch August 1, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenrussell kenrussell kenrussell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lexaknyazev @kenrussell