Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move texture extensions to draft; add tests #3576

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Move texture extensions to draft; add tests #3576

merged 1 commit into from
Aug 1, 2023

Conversation

lexaknyazev
Copy link
Member

No description provided.

kenrussell
kenrussell approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@kenrussell kenrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. One request for expanded comments in the texture mirroring test.

sdk/tests/conformance/extensions/ext-texture-mirror-clamp-to-edge.html Show resolved Hide resolved
sdk/tests/conformance2/extensions/webgl-stencil-texturing.html Show resolved Hide resolved
kenrussell
kenrussell approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@kenrussell kenrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the revised comment. Looks good.

@kenrussell kenrussell merged commit 3e71f3b into KhronosGroup:main Aug 1, 2023
1 check passed
@lexaknyazev lexaknyazev deleted the draft-texture-states branch August 1, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenrussell kenrussell kenrussell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lexaknyazev @kenrussell