Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UNPACK_COLORSPACE_CONVERSION_WEBGL now applies to all inputs, not just images. #3689

Merged
merged 2 commits into from
Sep 19, 2024
Merged

UNPACK_COLORSPACE_CONVERSION_WEBGL now applies to all inputs, not just images. #3689

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f19b19
UNPACK_COLORSPACE_CONVERSION_WEBGL now applies to all inputs, not jus…
kdashg Sep 5, 2024
599148e
Restrict to TexImageSource. (exclude e.g. ArrayBufferViews)
kdashg Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions specs/latest/1.0/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2769,7 +2769,7 @@ <h4>Texture objects</h4>

First, the source image data is conceptually converted to the color space specified by
the <a href="#DOM-WebGLRenderingContext-unpackColorSpace">unpackColorSpace</a>
attribute, except if the source image data is an <code>HTMLImageElement</code>, and
attribute, except if the
the <code>UNPACK_COLORSPACE_CONVERSION_WEBGL</code> pixel storage parameter is set
to <code>NONE</code>. <br><br>

Expand Down Expand Up @@ -4125,10 +4125,14 @@ <h3><a name="PIXEL_STORAGE_PARAMETERS">Pixel Storage Parameters</a></h3>

<dt><code>UNPACK_COLORSPACE_CONVERSION_WEBGL</code> of type <code>unsigned long</code>
<dd>If set to <code>BROWSER_DEFAULT_WEBGL</code>, then the browser's default colorspace conversion
is applied during subsequent <code>texImage2D</code> and <code>texSubImage2D</code> calls
taking <code>HTMLImageElement</code>. The precise conversions may be specific to both the browser
and file type. If set to <code>NONE</code>, no colorspace conversion is applied. The initial value
is <code>BROWSER_DEFAULT_WEBGL</code>.
(e.g. converting a display-p3 image to srgb)
is applied during subsequent texture data upload calls
(e.g. <code>texImage2D</code> and <code>texSubImage2D</code>) that take an argument of TexImageSource.

The precise conversions may be specific to both the browser and file type.
If set to <code>NONE</code>, no colorspace conversion is applied, other than conversion to RGBA.
(For example, a rec709 YUV video is still converted to rec709 RGB data, but not then converted to e.g. srgb RGB data)
The initial value is <code>BROWSER_DEFAULT_WEBGL</code>.

</dl>

Expand Down
Loading