Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KHR_materials_transmission #1698

Merged
merged 26 commits into from
Aug 26, 2020
Merged
Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
b6b5396
First draft of thin surface optical transparency extension
MiiBond Oct 22, 2019
a234697
Adding examples and more detail
MiiBond Oct 28, 2019
74ad767
Updating image
MiiBond Oct 28, 2019
f7af9c1
Add info about how roughness affects transmitted light
MiiBond Nov 5, 2019
a2cee58
Minor updates to wording
MiiBond Mar 13, 2020
45045c3
Remove IOR from example file
MiiBond Mar 13, 2020
8f10d45
Adjusting default value for transmissionFactor and updating readme
MiiBond Jun 17, 2020
fe76115
Specify that transmission is stored in the red channel of the texture
MiiBond Jun 18, 2020
af9ab1f
Fix reference to wrong default value
MiiBond Jun 23, 2020
56deeaa
Remove example for transmission
MiiBond Jun 24, 2020
f3256a7
Add comments about implementation expectations regarding layering
MiiBond Jul 3, 2020
35de2de
Merge branch 'master' of github.com:KhronosGroup/glTF into KHR_materi…
MiiBond Jul 8, 2020
fb83e3b
Add TOC, References and Khronos Copyright
MiiBond Jul 8, 2020
e429c4f
Update screenshot to remove refraction
MiiBond Jul 16, 2020
8df02df
Add suggested wordage to implementation notes
MiiBond Jul 16, 2020
3fe463e
Add note about baseColor needing to be converted to linear
MiiBond Jul 20, 2020
1410f7f
Update tint description
MiiBond Jul 21, 2020
c676ac9
Quick list of contributors
MiiBond Jul 27, 2020
a1af8f0
Quick list of contributors
MiiBond Jul 27, 2020
ae7ce0f
Couple of fixes
MiiBond Aug 6, 2020
d4875a8
Clarify tinting section
MiiBond Aug 6, 2020
885fa99
Add "This section is non-normative" clarification.
Aug 17, 2020
3776f24
Merge remote-tracking branch 'origin/master' into KHR_materials_trans…
emackey Aug 17, 2020
24c7755
Update copyright & schema description
emackey Aug 17, 2020
f9e8ce1
Markdown whitespace
emackey Aug 17, 2020
b936cf2
Address some comments
MiiBond Aug 17, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
212 changes: 212 additions & 0 deletions extensions/2.0/Khronos/KHR_materials_transmission/README.md

Large diffs are not rendered by default.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{
"$schema": "http://json-schema.org/draft-04/schema",
"title": "KHR_materials_transmission glTF extension",
"type": "object",
"description": "glTF extension that defines the optical transmission of a material.",
"allOf": [ { "$ref": "glTFProperty.schema.json" } ],
"properties": {
"transmissionFactor": {
"type": "number",
"description": "The base percentage of light transmitted through the surface.",
"default": 0.0,
"minimum": 0.0,
"maximum": 1.0,
"gltf_detailedDescription": "The base percentage of non-specularly reflected light that is transmitted through the surface. i.e. of the light that penetrates a surface (isn't specularly reflected), this is the percentage that is transmitted and not diffusely re-emitted."
},
"transmissionTexture": {
"allOf": [ { "$ref": "textureInfo.schema.json" } ],
"description": "A greyscale texture that defines the transmission percentage of the surface. This will be multiplied by transmissionFactor.",
"gltf_detailedDescription": "The percentage of non-specularly reflected light that is transmitted through the surface. i.e. of the light that penetrates a surface (isn't specularly reflected), this is the percentage is transmitted and not diffusely re-emitted. This will be multiplied by the transmissionFactor."
lexaknyazev marked this conversation as resolved.
Show resolved Hide resolved
},
"extensions": { },
"extras": { }
}
}