-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KHR_materials_thinfilm extension branch. #1742
KHR_materials_thinfilm extension branch. #1742
Conversation
Could we simplify the parameters for this to just thinFilmThickness and thinFilmIOR? I notice this is the parameterization used in the main reference paper here: https://hal.archives-ouvertes.fr/hal-01518344/document It is also the parameterization used in Autodesk Standard Surface:
https://autodesk.github.io/standard-surface/ Why was this more specific parameters chosen rather than the more physical parameterization that is also what everyone else is using? I highly advocate for the more physical ones as this allows for implementations to improve their physicality and we do not have to change the specification. |
The parametrization - in general for glTF materials - is to feed the GPU directly. So the parameters above are sufficient for a path tracer, but not for the GPU - depending of course which algorithms etc. we use. |
We can also discuss this in the break ;-) |
I created a branch here with my very minor proposed changes: I can not make a PR against your fork apparently. |
As this PR is more recent than KHR_materials_transmission, I have to assume there are reasons you prefer it — would you mind expanding on the motivation? Am I correct in understanding that this extension (if ratified) would provide the features of both |
The |
KHR_materials_transmission
KHR_materials_thickness
Would it be reasonable to rename this extension to something more like I ask because when I look at the long list of proposed PBR Next extensions, there are many that talk about "thin" and "coat" and IOR and transmission. I feel that this extension's name should distance itself from all those other proposed extensions. |
Update to latest version.
There is still intent from Threekit for pushing this towards a full standard. It is something that arises often. |
Yes, it is the roadmap for PBR Next. Maybe just join the Monday call. |
Latest changes.
Updating branch for changes.
We continue here #2027 |
No description provided.