KHR_lights_punctual: Clarify relationship between intensity and color. Also some grammar.
#2215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will-ca
force-pushed
the
punctual_grammar
branch
from
939bcab
to
0ef90df
Compare
Also fix some pre-existing grammar issues.
will-ca
force-pushed
the
punctual_grammar
branch
from
0ef90df
to
375e849
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2214 I ended up also making explicit the presumed separation between light intensity and light colour. (I.E. Light colour does not get normalized to match the intensity.) I also did some minor grammar and formatting changes/fixes.
This
cherry-picks those changes.This is not meant to change what the specification says, only make clearer and explicit what I believed was already presumed.