Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update KHR_materials_volume schema from json schema draft 04 to json schema draft 2020-12 #2380

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update KHR_materials_volume schema from json schema draft 04 to json schema draft 2020-12 #2380

wants to merge 1 commit into from

Conversation

teddemunnik
Copy link
Contributor

As discussed in #2049. This PR does the update just for the KHR_materials_volume extension.

@aaronfranke aaronfranke mentioned this pull request Jul 9, 2024
Open
aaronfranke
aaronfranke approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but see ongoing discussion in #2182 and #2049 for whether "$id" should be absolute or not. Ideally, the maintainers of this repo should decide on #2182 before merging this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronfranke aaronfranke aaronfranke approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teddemunnik @aaronfranke