Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common material spec: handling of specular exponent #510

Merged
merged 2 commits into from
Jan 12, 2016

Conversation

mlimper
Copy link
Contributor

@mlimper mlimper commented Dec 14, 2015

As discussed here, this PR adapts the spec to clarify handling of different values for the specular exponent.

Just a strawman proposal - it would probably also be a good solution to leave this special case of adapting values from [0,1] completely out. I guess that could facilitate writing correct reader / renderer implementations even more.

@pjcozzi
Copy link
Member

pjcozzi commented Dec 15, 2015

@mlimper this sounds like the client has to map [0, 1] to [0, 128]? Why can't this be done at conversion time? That is the glTF way: keep the client simple.

@mlimper
Copy link
Contributor Author

mlimper commented Dec 15, 2015

Why can't this be done at conversion time? That is the glTF way: keep the client simple.

Yes, I would also prefer that!
Actually, that's what I meant:

I guess that could facilitate writing correct reader / renderer implementations even more.

But then we need to adapt the current spec and remove the remark about handling different ranges differently (the passage about the Blinn-Torrance-Sparrow model).

@pjcozzi
Copy link
Member

pjcozzi commented Dec 15, 2015

That is all good with me.

@mlimper
Copy link
Contributor Author

mlimper commented Dec 15, 2015

Ok, thanks - I updated that.

Now, the PR removes the mentioned part of the spec about different interpretations of shininess.
Instead, an implementation note is added, clarifying the interpretation and illustrating typical usage by example (could maybe be more concise, I don't know).

@pjcozzi
Copy link
Member

pjcozzi commented Dec 16, 2015

OK with me. @tparisi are you good with this?

tparisi added a commit that referenced this pull request Jan 12, 2016
Common material spec: handling of specular exponent
@tparisi tparisi merged commit 8c3c449 into KhronosGroup:master Jan 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants