KieranBrantnerMagee · KieranBrantnerMagee · Mar 5, 2020 · Mar 5, 2020 · Mar 5, 2020 · Mar 6, 2020
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -6,11 +6,11 @@
 ###########
 
 # Catch all
-/sdk/ @mayurid
+/sdk/ @mayurid @lmazuel
 
 # Core
 /sdk/core/ @lmazuel @xiangyan99 @johanste
-/sdk/core/azure-core/ @xiangyan99 @bryevdv
+/sdk/core/azure-core/ @xiangyan99 @bryevdv @lmazuel
 
 # Service team
 /sdk/identity/ @chlowell @schaabs
@@ -37,7 +37,7 @@
 /sql/sql/ @jaredmoo
 /sdk/servicebus/ @annatisch @yunhaoling @YijunXieMS @KieranBrantnerMagee
 /sdk/synapse/ @aim-for-better @idear1203
-/sdk/textanalytics/ @kristapratico
+/sdk/textanalytics/ @kristapratico @iscai-msft
 
 # Management Plane
 /**/*mgmt*/ @zikalino

diff --git a/README.md b/README.md
@@ -43,6 +43,10 @@ Libraries which enable you to provision specific resources. They are responsible
 * File an issue via [Github Issues](../../issues)
 * Check [previous questions](https://stackoverflow.com/questions/tagged/azure+python) or ask new ones on StackOverflow using `azure` and `python` tags.
 
+### Community
+
+* Chat with other community members [![Join the chat at https://gitter.im/azure/azure-sdk-for-python](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/azure/azure-sdk-for-python?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
+
 ### Reporting security issues and security bugs
 
 Security issues and bugs should be reported privately, via email, to the Microsoft Security Response Center (MSRC) <secure@microsoft.com>. You should receive a response within 24 hours. If for some reason you do not, please follow up via email to ensure we received your original message. Further information, including the MSRC PGP key, can be found in the [Security TechCenter](https://www.microsoft.com/msrc/faqs-report-an-issue).

diff --git a/common/smoketest/event_hubs_async.py b/common/smoketest/event_hubs_async.py
@@ -54,7 +54,6 @@ async def send_and_receive_events(self, partition_id):
             # on_event will close the consumer_client which resumes execution
             on_event=self.on_event,
             on_error=self.on_error,
-            timeout=RECEIVE_TIMEOUT,
             starting_position=STARTING_POSITION
         )
 

diff --git a/common/smoketest/key_vault_certificates.py b/common/smoketest/key_vault_certificates.py
@@ -14,7 +14,8 @@ def __init__(self):
         # * AZURE_CLIENT_ID
         # * AZURE_CLIENT_SECRET
         # * AZURE_TENANT_ID
-        credential = DefaultAzureCredential()
+        authority_host = os.environ.get('AZURE_AUTHORITY_HOST') or KnownAuthorities.AZURE_PUBLIC_CLOUD
+        credential = DefaultAzureCredential(authority=authority_host)
         self.certificate_client = CertificateClient(
             vault_url=os.environ["AZURE_PROJECT_URL"], credential=credential
         )

diff --git a/common/smoketest/key_vault_certificates_async.py b/common/smoketest/key_vault_certificates_async.py
@@ -14,7 +14,8 @@ def __init__(self):
         # * AZURE_CLIENT_ID
         # * AZURE_CLIENT_SECRET
         # * AZURE_TENANT_ID
-        credential = DefaultAzureCredential()
+        authority_host = os.environ.get('AZURE_AUTHORITY_HOST') or KnownAuthorities.AZURE_PUBLIC_CLOUD
+        credential = DefaultAzureCredential(authority=authority_host)
         self.certificate_client = CertificateClient(
             vault_url=os.environ["AZURE_PROJECT_URL"], credential=credential
         )

diff --git a/common/smoketest/key_vault_keys.py b/common/smoketest/key_vault_keys.py
@@ -14,7 +14,8 @@ def __init__(self):
         # * AZURE_CLIENT_ID
         # * AZURE_CLIENT_SECRET
         # * AZURE_TENANT_ID
-        credential = DefaultAzureCredential()
+        authority_host = os.environ.get('AZURE_AUTHORITY_HOST') or KnownAuthorities.AZURE_PUBLIC_CLOUD
+        credential = DefaultAzureCredential(authority=authority_host)
         self.key_client = KeyClient(
             vault_url=os.environ["AZURE_PROJECT_URL"], credential=credential
         )

diff --git a/common/smoketest/key_vault_keys_async.py b/common/smoketest/key_vault_keys_async.py
@@ -14,7 +14,8 @@ def __init__(self):
         # * AZURE_CLIENT_ID
         # * AZURE_CLIENT_SECRET
         # * AZURE_TENANT_ID
-        credential = DefaultAzureCredential()
+        authority_host = os.environ.get('AZURE_AUTHORITY_HOST') or KnownAuthorities.AZURE_PUBLIC_CLOUD
+        credential = DefaultAzureCredential(authority=authority_host)
         self.key_client = KeyClient(
             vault_url=os.environ["AZURE_PROJECT_URL"], credential=credential
         )

diff --git a/common/smoketest/key_vault_secrets.py b/common/smoketest/key_vault_secrets.py
@@ -14,7 +14,8 @@ def __init__(self):
         # * AZURE_CLIENT_ID
         # * AZURE_CLIENT_SECRET
         # * AZURE_TENANT_ID
-        credential = DefaultAzureCredential()
+        authority_host = os.environ.get('AZURE_AUTHORITY_HOST') or KnownAuthorities.AZURE_PUBLIC_CLOUD
+        credential = DefaultAzureCredential(authority=authority_host)
         self.secret_client = SecretClient(
             vault_url=os.environ["AZURE_PROJECT_URL"], credential=credential
         )

diff --git a/common/smoketest/key_vault_secrets_async.py b/common/smoketest/key_vault_secrets_async.py
@@ -14,7 +14,8 @@ def __init__(self):
         # * AZURE_CLIENT_ID
         # * AZURE_CLIENT_SECRET
         # * AZURE_TENANT_ID
-        credential = DefaultAzureCredential()
+        authority_host = os.environ.get('AZURE_AUTHORITY_HOST') or KnownAuthorities.AZURE_PUBLIC_CLOUD
+        credential = DefaultAzureCredential(authority=authority_host)
         self.secret_client = SecretClient(
             vault_url=os.environ["AZURE_PROJECT_URL"], credential=credential
         )

diff --git a/common/smoketest/smoke_test_async.py b/common/smoketest/smoke_test_async.py
@@ -10,7 +10,7 @@
 from storage_blob_async import StorageBlobAsync
 
 
-def execute_async_smoke_tests:
+def execute_async_smoke_tests():
     print("")
     print("==========================================")
     print("   AZURE TRACK 2 SDKs SMOKE TEST ASYNC")

diff --git a/doc/dev/mgmt/cheatsheet.md b/doc/dev/mgmt/cheatsheet.md
@@ -20,15 +20,21 @@ For all packages:<br/>
 `python ./scripts/dev_setup.py`
 
 For a specific package:<br/>
-`python ./scripts/dev_setup.py -p azure-mgmt-servicename`
+
+```shell
+export PACKAGE=azure-mgmt-servicename
+python ./scripts/dev_setup.py -p $PACKAGE
+```
 
 ## Generate tags for multi-api Swagger Readme
 
 `python ./scripts/multi_api_readme_help.py /azure-rest-api-specs/specification/service/resource-manager/`
 
 ## Generate a package
 
-`python -m packaging_tools.generate_sdk -v -m restapi_path/readme.md`
+```shell
+python -m packaging_tools.generate_sdk -v -m restapi_path/readme.md
+```
 
 Regenerate multi-api client:<br/>
 `python ./scripts/multiapi_init_gen.py azure-mgmt-myservice`
@@ -60,11 +66,16 @@ Available options:
 
 ## ChangeLog
 
-Generate code report for last version on PyPI:<br/>`python -m packaging_tools.code_report --last-pypi azure-mgmt-myservice`
-
-Generate code report for version installed in current venv:<br/>`python -m packaging_tools.code_report azure-mgmt-myservice`
+Changelog is generated by performing following steps: 
+- generate code report for last version on PyPI:
+- generate code report for version installed in current venv
+- generate a markdown changelog
 
-Generate a markdown changelog:<br/>`python -m packaging_tools.change_log ./old_version_report.json ./new_version_report.json`
+```shell
+python -m packaging_tools.code_report --last-pypi $PACKAGE --output=$HOME/old.json
+python -m packaging_tools.code_report $PACKAGE --output=$HOME/new.json
+python -m packaging_tools.change_log $HOME/old.json $HOME/new.json
+```
 
 ## Tests
 

diff --git a/doc/sphinx/_static/js/get_options.js b/doc/sphinx/_static/js/get_options.js
@@ -45,21 +45,11 @@ function hideSelectors(selectors){
 
 function populateOptions(optionSelector, otherSelectors){
   if(currentPackage()){
-    var versionRequestUrl = "https://azuresdkdocs.blob.core.windows.net/$web?restype=container&comp=list&prefix=" + SELECTED_LANGUAGE + "/" + currentPackage() + "/versions/"
+    var versionRequestUrl = "https://azuresdkdocs.blob.core.windows.net/$web/" + SELECTED_LANGUAGE + "/" + currentPackage() + "/versioning/versions"
 
     httpGetAsync(versionRequestUrl, function(responseText){
       if(responseText){
-        data_stored = responseText
-
-        parser = new DOMParser();
-        xmlDoc = parser.parseFromString(responseText,"text/xml");
-
-        nameElements = Array.from(xmlDoc.getElementsByTagName('Name'))
-        options = []
-
-        for (var i in nameElements){
-          options.push(nameElements[i].textContent.split('/')[3])
-        }
+        options = responseText.match(/[^\r\n]+/g)
 
         populateVersionDropDown(optionSelector, options)
         showSelectors(otherSelectors)
@@ -93,19 +83,11 @@ function getPackageUrl(language, package, version){
 
 function populateIndexList(selector, packageName)
 {
-  url = "https://azuresdkdocs.blob.core.windows.net/$web?restype=container&comp=list&prefix=" + SELECTED_LANGUAGE + "/" + packageName + "/versions/"
+  url = "https://azuresdkdocs.blob.core.windows.net/$web/" + SELECTED_LANGUAGE + "/" + packageName + "/versioning/versions"
 
   httpGetAsync(url, function (responseText){
     if(responseText){
-      parser = new DOMParser();
-      xmlDoc = parser.parseFromString(responseText,"text/xml");
-
-      nameElements = Array.from(xmlDoc.getElementsByTagName('Name'))
-      options = []
-
-      for (var i in nameElements){
-        options.push(nameElements[i].textContent.split('/')[3])
-      }
+      options = responseText.match(/[^\r\n]+/g)
 
       for (var i in options){
         $(selector).append('<li><a target="new" href="' + getPackageUrl(SELECTED_LANGUAGE, packageName, options[i]) + '">' + options[i] + '</a></li>')

diff --git a/doc/sphinx/conf.py b/doc/sphinx/conf.py
@@ -59,7 +59,7 @@
 
 intersphinx_mapping = {
     # Dependencies
-    'python': ('https://docs.python.org/3.8', None),
+    'python': ('https://docs.python.org/3.8', ('/usr/share/doc/python3-doc/html/objects.inv', None)),
     'msrestazure': ('http://msrestazure.readthedocs.io/en/latest/', None),
     'msrest': ('http://msrest.readthedocs.io/en/latest/', None),
     'requests': ('https://requests.kennethreitz.org/en/master/', None),

diff --git a/doc/sphinx/package_service_mapping.json b/doc/sphinx/package_service_mapping.json
@@ -861,6 +861,11 @@
     "service_name": "Cosmos",
     "manually_generated": true
   },
+  "azure-search-documents": {
+    "category": "Client",
+    "service_name": "Search",
+    "manually_generated": true
+  },
   "azure-keyvault-keys": {
     "category": "Client",
     "service_name": "Keyvault",

diff --git a/eng/.docsettings.yml b/eng/.docsettings.yml
@@ -105,6 +105,7 @@ known_content_issues:
   - ['sdk/core/azure-mgmt-nspkg/README.rst', 'nspkg and common']
   - ['sdk/core/azure-nspkg/README.rst', 'nspkg and common']
   - ['sdk/keyvault/azure-keyvault-nspkg/README.md', 'nspkg and common']
+  - ['sdk/search/azure-search-nspkg/README.md', 'nspkg and common']
   - ['sdk/storage/azure-storage-blob/samples/README.md', 'nspkg and common']
   - ['sdk/storage/azure-storage-file-datalake/samples/README.md', 'nspkg and common']
   - ['sdk/storage/azure-storage-file-share/samples/README.md', 'nspkg and common']

diff --git a/eng/common/Extract-ReleaseNotes.ps1 b/eng/common/Extract-ReleaseNotes.ps1
@@ -56,16 +56,7 @@ else
   if ($releaseNotes.ContainsKey($VersionString)) 
   {
     $releaseNotesForVersion = $releaseNotes[$VersionString].ReleaseContent
-    $releaseNotesArray = $releaseNotesForVersion.Split([Environment]::NewLine)
-    $processedNotes = New-Object System.Collections.ArrayList
-    foreach ($line in $releaseNotesArray) 
-    {
-      $lineIsTitle = $line.Startswith('#') -And ($line -match $RELEASE_TITLE_REGEX)
-      if (-Not $lineIsTitle) 
-      {
-        $processedNotes.Add($line) > $null
-      }
-    }
+    $processedNotes = $releaseNotesForVersion -Split [Environment]::NewLine | where { $_ -notmatch $RELEASE_TITLE_REGEX }
     return $processedNotes -Join [Environment]::NewLine
   }
   Write-Error "Release Notes for the Specified version ${VersionString} was not found"

diff --git a/eng/common/TestResources/New-TestResources.cmd b/eng/common/TestResources/New-TestResources.cmd
@@ -0,0 +1,17 @@
+@echo off
+
+REM Copyright (c) Microsoft Corporation. All rights reserved.
+REM Licensed under the MIT License.
+
+setlocal
+
+for /f "usebackq delims=" %%i in (`where pwsh 2^>nul`) do (
+    set _cmd=%%i
+)
+
+if "%_cmd%"=="" (
+    echo Error: PowerShell not found. Please visit https://github.com/powershell/powershell for install instructions.
+    exit /b 2
+)
+
+call "%_cmd%" -NoLogo -NoProfile -File "%~dpn0.ps1" %*