Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stepchange event #60

Closed
brianpkelley opened this issue Jan 11, 2019 · 2 comments
Closed

stepchange event #60

brianpkelley opened this issue Jan 11, 2019 · 2 comments

Comments

@brianpkelley
Copy link
Contributor

I noticed the stepchange event was not being fired when clicking on title linkes.

Moving/adding "stepper.dispatchEvent(events.STEPCHANGE);" from openStep, nextStep, prevStep and into _openAction fixed the issue.
@Kinark
Copy link
Owner

Kinark commented Jan 12, 2019 •
edited
Loading

This is a pretty smart solution, it's really stupid of me not to put it on the global _openAction method lol
Thank you!
I'm about to release a version, so it's good that you found this bug.
I'd be really grateful if you could submit a PR :D

@brianpkelley brianpkelley mentioned this issue Jan 16, 2019
Merged
@Kinark
Copy link
Owner

Kinark commented Jan 21, 2019

Fixed in PR #61

@Kinark Kinark closed this as completed Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brianpkelley @Kinark